Page 1 of 1

1.9: International transfers bug

Posted: Tue Jun 07, 2005 8:35 pm
by MarkC
Suppose we have a country definition with at least one international cup, but none of those cups contain "generated" teams in Round 1. When the program creates an international transfer before any teams have been generated, it crashes because it tries to choose a random team from a list of zero.

For the time being, I'm making sure that all my countries include at least the Cup Winners' Cup as well as any of my own "local" international cups. I could instead define a "dummy" cup with no national teams in it, but then the user would wonder where the transfers are coming from.

It would be nice to have a cup property "no_transfers" to stop teams from a cup going onto the transfer list. I know this bit really belongs in "Feature Requests" but it's so closely related to the bug that I thought I'd mention it here.

Re: 1.9: International transfers bug

Posted: Wed Jun 08, 2005 7:38 am
by gyboth
MarkC wrote:It would be nice to have a cup property "no_transfers" to stop teams from a cup going onto the transfer list. I know this bit really belongs in "Feature Requests" but it's so closely related to the bug that I thought I'd mention it here.
no, it's a bug, not a feature request. the tag would just remedy a weakness of the source code.

i noticed that the function choosing a team for the transfer list is faulty anyway because when the dice tells the program to take a player from an international cup, it just includes the international teams in the list of teams to choose from, which isn't the same at all.

i'm going to fix this by adding a better check for international teams, so that 'no international teams in the game' automatically leads to choosing a league team for the transfer list.

gyözö

Posted: Wed Jun 08, 2005 5:44 pm
by gyboth
:arrow: this should be fixed now. please try it out, i don't have a definition w/o cups handy ;-)

gyözö

Posted: Thu Jun 09, 2005 7:27 pm
by MarkC
[quote]:arrow: this should be fixed now. please try it out, i don't have a definition w/o cups handy ;-)

I just ran through a load of seasons without any crashes. So I think we can consider it fixed.

Excellent job :D Ta.

(Yes, we say it in England as well ;-) In some parts, at least.)

Posted: Fri Jun 10, 2005 3:27 pm
by mom2pp
MarkC wrote:Yes, we say it in England as well ;-) In some parts, at least.
ta is said quite a bit in scotland too