1.9: International transfers bug

Here you can... report bugs. Open a new thread for each bug, please.
Post Reply
MarkC
Posts: 96
Joined: Tue Mar 29, 2005 10:34 pm

1.9: International transfers bug

Post by MarkC »

Suppose we have a country definition with at least one international cup, but none of those cups contain "generated" teams in Round 1. When the program creates an international transfer before any teams have been generated, it crashes because it tries to choose a random team from a list of zero.

For the time being, I'm making sure that all my countries include at least the Cup Winners' Cup as well as any of my own "local" international cups. I could instead define a "dummy" cup with no national teams in it, but then the user would wonder where the transfers are coming from.

It would be nice to have a cup property "no_transfers" to stop teams from a cup going onto the transfer list. I know this bit really belongs in "Feature Requests" but it's so closely related to the bug that I thought I'd mention it here.
gyboth
Site Admin
Posts: 1421
Joined: Sat Dec 18, 2004 8:42 am
Location: Passau, Germany
Contact:

Re: 1.9: International transfers bug

Post by gyboth »

MarkC wrote:It would be nice to have a cup property "no_transfers" to stop teams from a cup going onto the transfer list. I know this bit really belongs in "Feature Requests" but it's so closely related to the bug that I thought I'd mention it here.
no, it's a bug, not a feature request. the tag would just remedy a weakness of the source code.

i noticed that the function choosing a team for the transfer list is faulty anyway because when the dice tells the program to take a player from an international cup, it just includes the international teams in the list of teams to choose from, which isn't the same at all.

i'm going to fix this by adding a better check for international teams, so that 'no international teams in the game' automatically leads to choosing a league team for the transfer list.

gyözö
Press any key to continue or any other key to quit.
gyboth
Site Admin
Posts: 1421
Joined: Sat Dec 18, 2004 8:42 am
Location: Passau, Germany
Contact:

Post by gyboth »

:arrow: this should be fixed now. please try it out, i don't have a definition w/o cups handy ;-)

gyözö
Press any key to continue or any other key to quit.
MarkC
Posts: 96
Joined: Tue Mar 29, 2005 10:34 pm

Post by MarkC »

[quote]:arrow: this should be fixed now. please try it out, i don't have a definition w/o cups handy ;-)

I just ran through a load of seasons without any crashes. So I think we can consider it fixed.

Excellent job :D Ta.

(Yes, we say it in England as well ;-) In some parts, at least.)
mom2pp
Posts: 193
Joined: Sat Jan 29, 2005 5:47 pm
Location: Scotland

Post by mom2pp »

MarkC wrote:Yes, we say it in England as well ;-) In some parts, at least.
ta is said quite a bit in scotland too
Haven't u people ever heard of closing a goddam door?
Post Reply