Page 1 of 1
Mexico.
Posted: Sun Feb 18, 2007 8:38 pm
by chunter
Here I thought I finished up early... there may be more changes on Tuesday if the new feature in the SVN works right (I'm downloading it as I write this
) but for now...
This Mexico definition accounts for the addition of the SuperLiga tournament to be held this July (If I'm remembering correctly.) This definition accounts for sides that qualified for Libertadores and therefore may not be able to take part in both competitions concurrently. This will be revised in a future update.
It does NOT have the InterLiga tournament, the quick round-robin qualifier that chooses the Mexican teams that will enter Libertadores, because without the new 'two matchdays per week' feature it would have to be at the same time as the fall playoff. More on that later.
In the meantime, this definition was finished last night and is playable:
http://chunter.homeip.net/bygfoot/mexico.tgz
Enjoy!
Posted: Wed Feb 21, 2007 9:11 am
by mrsmola
I added the Mexican definitions to subversion.
Mark
Posted: Sun Mar 04, 2007 6:18 pm
by chunter
There was at least one change I made that made this country playable again. There was a mistake in the promotion/relegation that caused a segfault at the end of the season.
http://chunter.homeip.net/bygfoot/mexico.tgz
Posted: Wed Mar 07, 2007 10:39 am
by mrsmola
The game writes critical errors to the console by playing the Mexican definition. I tested all versions of the Mexican definition we have in subversion. They all have the problem.
After the live game, during the calculation of the results, the game writes the errors.
(bygfoot:6904): GLib-CRITICAL **: g_strrstr: assertion `needle != NULL' failed
(bygfoot:6904): GLib-CRITICAL **: g_strrstr: assertion `needle != NULL' failed
(bygfoot:6904): GLib-CRITICAL **: g_strrstr: assertion `needle != NULL' failed
(bygfoot:6904): GLib-CRITICAL **: g_strrstr: assertion `needle != NULL' failed
(bygfoot:6904): GLib-CRITICAL **: g_strrstr: assertion `needle != NULL' failed
Other definitions like USA, Japan don't have that problem.
Mark
Posted: Sat Mar 10, 2007 9:07 pm
by chunter
I'll start playing it and staring at it to see if I can figure it out. Do you know what part of the program the error messages pertain to? (It might help me find the mistake faster...)
Posted: Sun Mar 11, 2007 2:26 pm
by gyboth
chunter wrote:I'll start playing it and staring at it to see if I can figure it out. Do you know what part of the program the error messages pertain to? (It might help me find the mistake faster...)
i believe it's rather something i've done (namely, exclude directories containing "svn" in their names from the support dir list).
i'll look into the problem tonight (or later
).
gyözö
Posted: Sat Mar 24, 2007 7:13 pm
by gyboth
hi,
the bug's fixed. it occurred because there's no sid given in the country file, and in one function (in job.c) an existing sid is expected. i've solved the problem by initialising the country sid with "NONAME" instead of NULL.
gyözö
Posted: Mon Mar 26, 2007 4:12 am
by chunter
That's embarrassing, sorry about that...
Posted: Mon Mar 26, 2007 6:50 am
by gyboth
chunter wrote:That's embarrassing, sorry about that...
don't be, it was a bug in the code. the program should have aborted with a clear error message, not just printed a few generic g_strrstr errors.
gyözö
Posted: Mon Apr 02, 2007 2:30 pm
by mrsmola
I added the actual definitions of Mexico to the subversion repository
Mark