1.7.3: Job offer faulty

[gyboth]

when you get a job offer and accept, you sometimes end up with a
completely different team than the one that offered you the job.

the bug is hard to reproduce, so i'm not sure i'll be able to fix it quickly;
on the other hand, i doesn't appear often, i think.

as always, i'd be glad to receive any hints on when and why the bug occurs.

gyözö

[Guest]

I had some problem with job offers and objective.
So i look into the code and found that job_offer_window is not modal !!
I think it should be ?

More other, -maybe i'm wrong - it seems that if the player cancel the "job offers", status var is not reset, it's always > 900000 so :

Code: Select all

 /* player wasn't fired */
    if( status < 900000 && 
	(my_team_played(week - 1) ||
	 my_team_played(week)) )
    {
	if(my_team_played(week - 1))
	    show_results(3);
	else if(week < 49)
	    callback_show_preview();

is never execute if user clic on cancel...

[GeoVah]

herr its was me !!!

[gyboth]

So i look into the code and found that job_offer_window is not modal !!

all popup windows are modal in a way; main window sensitivity is set by the program itself.

More other, -maybe i'm wrong - it seems that if the player cancel the "job offers", status var is not reset, it's always > 900000 so : <snip>
is never execute if user clic on cancel...

that's ok because if the user clicks on 'cancel' the game is over and the program exits.

gyözö

[GeoVah]

Ok but when user clic on cancel when a job offers windows appears -when he won lot of match, left pane (player list) is not set/redraw correctly

[gyboth]

Ok but when user clic on cancel when a job offers windows appears -when he won lot of match, left pane (player list) is not set/redraw correctly

all right, gonna check it. the next days are 1.7 debugging time, anyway.

gyözö

[gyboth]

Ok but when user clic on cancel when a job offers windows appears -when he won lot of match, left pane (player list) is not set/redraw correctly

i've corrected this.

gyözö

[vector]

slightly different error and more a user fault than anything
i wasnt thinking when the job offer came up and hit close window instead of accept or reject.
sure enough the window closed but bygfoot remained ghosted
ooops
I had to exit the game

[gyboth]

slightly different error and more a user fault than anything
i wasnt thinking when the job offer came up and hit close window instead of accept or reject.
sure enough the window closed but bygfoot remained ghosted
ooops
I had to exit the game

you mean the main window remained insensitive, i guess. i'm going to correct this.

gyözö

[vector]

yes insensitive.
greyed out
ghosted
unfocused

[gyboth]

fixed in the cvs. i've also changed some build files (due to an update of my system), i hope everything still works on other systems (tell me if it is not so).

gyözö

[usernamed]

Hi Gyozo,

I've now had the job offer bug hit me twice in 1.8.0. I was offered a job with Walsall, when I accepted it I found I was boss of Leicester (different division and everything)

Later I was offered my dream job at Chelsea, when I accepted it I had a completely different set of players but I was still at Leicester! Not just on the main game screen but in the league table as well.

I can provide you with my save game if it would help.

[Usernamed]

...I've just realised that the only thing I did differently from usual when starting the game was to select the 'load only names from team definition file' checkbox, instead of the 'load my team from definitions files' checkbox

Don't know if that helps to narrow it down.

Thanks.

[gyboth]

Don't know if that helps to narrow it down.

i don't think it does, those should be completely different things. but now that there's a fresh report, i'm going to have a bug-hunting session again (i failed to find the bug earlier).

sorry 'bout your dream job

gyözö

[gyboth]

all right, this time i could reproduce the bug (in contrast to last time i looked for it). thus it was fairly easy to find and correct

bug is fixed in the cvs; i've also made a revision, use the update script to patch your source package.

gyözö