Hey tstellar. Well, I wanted to post and ask you questions about your changes you did with the bygfoot code over at github, in relation to your changes to the Faroe Islands country definition. The only problem was that some questions I would ask would be just as simply answered if I actually played the game and definition in question, so I did that. So, here are my thoughts and comments.
To begin with, I downloaded the windows 64-bit version and played it on my computer, with nothing more added. I have a 64-bit version of Windows 7 professional on this netbook in a separate partition. I'll add though that my firewall program Comodo, decided to sandbox the program when running it, so it was run with a virtual boundary around it, which was fine as it still played. So as I copied the contents of the zip file onto my desktop in windows, whenever I would run it, it would just run in a virtual sandbox. Of note, the russian flag png file was still wrong.
Now as I said, I played the Faroe Islands definition, and I have a few comments about the definition itself, but also about the program. When I tried to go from Season 1, week 50 to Season 2, week 1, the program crashed on me. I do have the error logs of bygfoot.log and stderr.log, which I was able to find. Their contents are as follows:
bygfoot.log:
"2021-01-12T09:30:15.669734Z Could not open file 'C:\Users\HPMini\Desktop\bygfoot-2.3.3-unofficial\saves\last_country' in mode 'w'."
"2021-01-12T09:30:15.669734Z file_store_text_in_saves: failed to store 'faroe_islands' in file 'C:\Users\HPMini\Desktop\bygfoot-2.3.3-unofficial\saves\last_country'"
"2021-01-12T22:20:07.729345Z cup_load_choose_team_generate: not enough teams (that don't participate in international cups yet) found in chooseteam scotland1 for cup UEFA Cup (1 specified, 0 found)."
"2021-01-12T22:20:07.760546Z Press RETURN. Program will exit."
"2021-01-12T22:25:33.074765Z cup_load_choose_team_generate: not enough teams (that don't participate in international cups yet) found in chooseteam scotland1 for cup UEFA Cup (1 specified, 0 found)."
"2021-01-12T22:25:33.090365Z Press RETURN. Program will exit."
"2021-01-12T22:35:19.494596Z cup_load_choose_team_generate: not enough teams (that don't participate in international cups yet) found in chooseteam portugal1 for cup UEFA Cup (1 specified, 0 found)."
"2021-01-12T22:35:19.510196Z Press RETURN. Program will exit."
Now when I started, I did not find any "saves" directory to save any progress games anywhere, so I did end up creating it outside of the game before saving any games there. And as I tried to progress from Season 1, week 50 to Season 2, week 1 on more than one occasion, which is likely why you see multiple times that the "program will exit" listed, the program did crash as I mentioned earlier. And whether or not these errors are from the included definitions OR the coding of the program, I can't say since I used the definitions that you included with the program. I'm just reporting this issue to you and I may try the program again with different definitions, but for the moment, not yet.
As for the
stderr.log file, it has the following contents:
"(bygfoot.exe:1160): Gtk-WARNING **: Could not find the icon 'gtk-file'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
http://icon-theme.freedesktop.org/releases"
"** (bygfoot.exe:1160): WARNING **: cup_load_choose_team_generate: not enough teams (that don't participate in international cups yet) found in chooseteam portugal1 for cup UEFA Cup (1 specified, 0 found)."
"** (bygfoot.exe:1160): WARNING **: Press RETURN. Program will exit."
So with this one, part seems definition based and part seems like something else.
Now, the rest of this post will be about the definitions and the additions you did to include new tags and all. At this post
here, it was titled "
Re: svn2git conversion plus a few improvements", you mentioned that you "added some additional promotion logic for promoting / relegating reserve teams." Could you explain a little further, as I am curious about this?
Now when I played the Faroe Islands definitions, I played as the team of N. Runavik V, which was in the fourth tier and having one of the lowest average talent scores in the tier, which was a nice challenge. As it was a reserve team, what limitations, if any, would be placed upon me for playing as this particular team? As the user, could I select this reserve team and start off in the 4th tier and work my way up to the top tier and qualify for either the UEFA Cup or UEFA Champions League (in this example) or would the promotion logic you added to bygfoot stop me from progressing beyond a certain point? And if so, why? If this same logic will stop me from progressing to the top when promotion and relegation is available to the country definition, then why am I, as a user, allowed to pick this particular team to play when the program won't allow me to do what I want to do with it? Again, I only got to play 1 season before the game crashed so I can't answer this question just yet, but if I try a different set of definitions, I might be able to answer the question of how far it will let me go with this team. I guess tstellar, for computer controlled teams, the promotion logic can make sense, but when the user wishes to play those teams, that same promotion logic may not be as nice as it would be otherwise.
As I made notes about the game, probably the biggest note I have would be about the timing of the definition in general, as national play ends in week 35 and the overall game play doesn't end until week 50, which is the last week of the season. I'll tell you the same thing I told billys_boots about timings...you've got a whole lot of open space out there. You can spread the game play around to fill up a lot more space if you want. You don't have to follow the rules of the actual schedule, although when I think of it, it seems like you are taking the schedule too literally. As game play seems to take place between March and October, think of this in the form of a calendar year, from January to December, if you will. Even then, you'll have about 9 or 10 weeks before and after your national game play anyways, but the longer the national game play goes on, the longer your trade window will remain open. Right now, it is open for only 27 weeks. Your Supercup takes place in week 35, of which you have 15 more weeks to wait until the last week of the season. You could easily have the Supercup in week 10, have the season start in week 11, and STILL have a few weeks left after the last scheduled national game until the end of the season, and your trade window would go from 27 weeks long to maybe 35 to 37 weeks long. It is all about spacing things out as you have 49 weeks available to you to play games. You don't have to compress everything. And the supercup in the first season won't have the true competitors in it but that isn't important as you'll be playing it for more than one season and the following seasons will have the correct teams playing in it.
I guess one thing I also noticed was the new cup tag of <week_gap>, within the <cup_round> tag. That tag appears to have the same function as the <break_in> tag that is available in the header section of a cup file, but a little more easier for the user as less calculations are needed.
An example of the <break_in> tag would be "<break_in length="1">19</break_in>", which would imply having a 1 week break in competition, beginning in week 19. So the function of your tag already exists with the function of another tag, although it might make it less complicated for the definition creator.
So, I guess that is it for now. This whole reserve team logic is making me wonder and if you could explain it further, that would be appreciated. I guess I'm just wondering who you are expecting the users of this definition to play as and how much of a challenge are they expecting to get. I'm also wondering how this reserve team logic can translate to other country definitions, especially when it comes to cup file coding. Oh well. Anyways, that's all for now,
Will aka will_the_canuck